Skip to content

Update php-cs-fixer configuration#3886

Merged
alanpoulain merged 4 commits into
api-platform:masterfrom
drupol:update-php-cs-fixer-configuration
Dec 5, 2020
Merged

Update php-cs-fixer configuration#3886
alanpoulain merged 4 commits into
api-platform:masterfrom
drupol:update-php-cs-fixer-configuration

Conversation

@drupol

@drupol drupol commented Dec 5, 2020

Copy link
Copy Markdown
Contributor
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tickets fixes #3884
License MIT

#SymfonyHackday

Comment thread src/Bridge/Symfony/Bundle/DependencyInjection/Configuration.php Outdated
@alanpoulain

Copy link
Copy Markdown
Member

Would be nice to solve the PHPStan issues too (they are not related).

@drupol

drupol commented Dec 5, 2020

Copy link
Copy Markdown
Contributor Author

Would be nice to solve the PHPStan issues too (they are not related).

I guess this should be fixed in another ticket, this is a bit out of scope of this ticket. WDYT?

@alanpoulain

Copy link
Copy Markdown
Member

We could, but it's always better to have a green CI when merging a PR. It's as you want 🙂 The best way is to make a PR to solve the PHPStan issues, merging it, then rebase this one.

@drupol

drupol commented Dec 5, 2020

Copy link
Copy Markdown
Contributor Author

Ok I understand the issue.

Actually, API Platform supports doctrine/inflector ^1 and ^2.
The API Platform Inflector is a facade that can use either version 1 or 2.

This is why PHPStan complains. You cannot install both versions of the same package, and thus, it makes a problem.

I'll see how we can tackle this quickly and include a commit to fix that.

@alanpoulain
alanpoulain merged commit 43335fd into api-platform:master Dec 5, 2020
@alanpoulain

Copy link
Copy Markdown
Member

Thank you @drupol!

@drupol
drupol deleted the update-php-cs-fixer-configuration branch December 5, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CS: revert CS changes in Configuration.php

2 participants